Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the socket options related code from CUDT into a separate class CSocketConfig #1549

Closed
maxsharabayko opened this issue Sep 14, 2020 · 1 comment
Closed

Move the socket options related code from CUDT into a separate class CSocketConfig #1549

maxsharabayko opened this issue Sep 14, 2020 · 1 comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Milestone
v1.4.3

Comments

@maxsharabayko
Copy link
Collaborator

Move the socket options related code from CUDT into a separate class CSocketConfig under the srt namespace.

For example, CUDT::setOpt(..) is a quite long function than could be moved from CUDT and split per option.
Meaning, case SRTO_PACKETFILTER: becomes something like CSocketConfig::SetPacketFilter(..).

SRT version: v1.4.1
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Sep 14, 2020
@maxsharabayko maxsharabayko added this to the Parking Lot milestone Sep 14, 2020
@maxsharabayko maxsharabayko modified the milestones: Parking Lot, v1.4.3 Jan 25, 2021
@maxsharabayko
Copy link
Collaborator Author

#1776 mostly addressed this.
Closing as the remaining possible things to do are not that important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.3
Development

No branches or pull requests
1 participant
@maxsharabayko