Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Extra ACK is sent at the start of a connection (due to an uninitialized variable) #2829

Closed
maxsharabayko opened this issue Dec 6, 2023 · 1 comment · Fixed by #2832
Closed

[BUG] Extra ACK is sent at the start of a connection (due to an uninitialized variable) #2829

maxsharabayko opened this issue Dec 6, 2023 · 1 comment · Fixed by #2832
Assignees
@yomnes0
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Milestone
v1.5.4

Comments

@maxsharabayko
Copy link
Collaborator

maxsharabayko commented Dec 6, 2023 •
edited

After PR #2745 once a connection is established both sides (sender and receiver) without any reason send the first full ACK with the initial sequence number.

To Reproduce

Start a Wireshark capture and run:

srt-xtransmit generate "srt://:4200" --enable-metrics -v --sendrate 5Mbps --duration 3s

srt-xtransmit receive "srt://127.0.0.1:4200" --enable-metrics -v

In the capture right after the handshake you will see those two useless ACKs.
image

SRT Version Affected : v1.5.3.
@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Dec 6, 2023
@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Dec 6, 2023
yomnes0 added a commit to yomnes0/srt that referenced this issue Dec 11, 2023
@yomnes0
Fix for bug Haivision#2829
810df90 
Add an initialization of m_bBufferWasFull to false when starting a connection
@yomnes0
Copy link
Collaborator

yomnes0 commented Dec 11, 2023

See #2832

@maxsharabayko maxsharabayko mentioned this issue Dec 11, 2023
Merged
@maxsharabayko maxsharabayko changed the title [BUG] Extra ACK is sent at the start of a connection [BUG] Extra ACK is sent at the start of a connection (due to an uninitialized variable) Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yomnes0 yomnes0

Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
v1.5.4
Development

Successfully merging a pull request may close this issue.

Fix extra ack being sent after a connection is established yomnes0/srt
2 participants
@maxsharabayko @yomnes0