Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Crypto: Reset the passphrase in memory on destruction for security reasons #1010

Merged
merged 1 commit into from Dec 13, 2019
Merged

[core] Crypto: Reset the passphrase in memory on destruction for security reasons #1010

merged 1 commit into from Dec 13, 2019

Conversation

ethouris
Copy link
Collaborator

No description provided.

@ethouris ethouris added [core] Area: Changes in SRT library core Priority: High Status: Review Needed Type: Bug Indicates an unexpected problem or unintended behavior labels Dec 10, 2019
@ethouris ethouris added this to Needs review in Development via automation Dec 10, 2019
@ethouris ethouris added this to the v1.5.0 milestone Dec 10, 2019
@maxsharabayko
Copy link
Collaborator

Please describe what does this fix?

@ethouris
Copy link
Collaborator Author

The CCryptoControl::close() function rewrites the memory that contains the passphrase - it was intended to be called before destruction of the application. This is for security reasons.

Development automation moved this from Needs review to Reviewer approved Dec 10, 2019
maxsharabayko
maxsharabayko approved these changes Dec 10, 2019
View reviewed changes
Copy link
Collaborator

@maxsharabayko maxsharabayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rndi Please merge renaming the commit to

[core] Crypto: Reset the passphrase in memory on close
for security reasons

@ethouris ethouris changed the title Fixed: close crypto in destructor [core] Crypto: Reset the passphrase in memory on destruction for security reasons Dec 10, 2019
@rndi rndi merged commit e55ce4a into Haivision:master Dec 13, 2019
Development automation moved this from Reviewer approved to Done Dec 13, 2019
@mbakholdina mbakholdina modified the milestones: v1.5.0, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsharabayko maxsharabayko maxsharabayko approved these changes

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Priority: High Type: Bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Development
  
Done
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ethouris @maxsharabayko @rndi @mbakholdina