Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unique send/receive stats #1283

Merged
merged 2 commits into from May 12, 2020

Conversation

ethouris
Copy link
Collaborator

No description provided.

@ethouris ethouris added Priority: High Type: Enhancement Indicates new feature requests [core] Area: Changes in SRT library core Impact: Significant labels May 11, 2020
@ethouris ethouris added this to the v1.5.0 milestone May 11, 2020
@ethouris ethouris self-assigned this May 11, 2020
@ethouris ethouris added this to Needs Review in Development May 11, 2020
srtcore/core.cpp Outdated Show resolved Hide resolved
srtcore/srt.h Show resolved Hide resolved
Development automation moved this from Needs Review to Reviewer Approved May 12, 2020
Copy link
Collaborator

@maxsharabayko maxsharabayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.
Undecrypted packets are not included in the pktRecvUnique stats, which is correct, as they are included in pktRecvDrop.
Then we are able to calculate drop ratio on a single link and on a bonded link.

Dropped (Unrecovered) Packets Ratio = pktRcvDrop / (pktRecvUnique + pktRcvDrop)

@maxsharabayko maxsharabayko merged commit 32134d2 into Haivision:master May 12, 2020
Development automation moved this from Reviewer Approved to Done May 12, 2020
@maxsharabayko maxsharabayko mentioned this pull request May 12, 2020
33 tasks
@mbakholdina mbakholdina modified the milestones: v1.5.0, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Priority: High Type: Enhancement Indicates new feature requests
Projects
No open projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants