Fixed getting next available unit from CUnitQueue #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Bug
maxsharabayko
commented
Jun 9, 2020
ethouris
reviewed
Jun 9, 2020
maxsharabayko
force-pushed
the
hotfix/unitqueue-getavail
branch
from
57d8352
to
835be34
Compare
Covers some issues related to Local storage depleted issue Haivision#486
maxsharabayko
force-pushed
the
hotfix/unitqueue-getavail
branch
from
835be34
to
16d1ece
Compare
Refers to issue Haivision#486 getting available uit to receive a packet
maxsharabayko
force-pushed
the
hotfix/unitqueue-getavail
branch
from
16d1ece
to
129d2de
Compare
ethouris
approved these changes
Jun 10, 2020
maxsharabayko
added a commit
that referenced
this pull request
Jun 11, 2020
This was referenced Jun 11, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one set of bugs related to #486
CUnitQueue::getNextAvailUnit()has several issues. They are described in the review comments to the code.This PR consists of three commits:
size()andcapacity()getters toCUnitQueue. Needed for unit tests.CUnitQueue.CUnitQueue::getNextAvailUnit()