Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework of C++11 and posix sync #1379

Merged
merged 6 commits into from Aug 11, 2020
Merged

Rework of C++11 and posix sync #1379

merged 6 commits into from Aug 11, 2020

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Jun 25, 2020 •
edited

Fixes #1104

Actually all required changes were split off into other PRs, so this just completes the changes with the remaining cosmetics:

  1. Consolidate the contents of sync.cpp under one namespace
  2. Remove suprefluous conditionals.

@ethouris ethouris self-assigned this Jun 25, 2020
@ethouris ethouris added [build] Area: Changes in build files [core] Area: Changes in SRT library core Impact: Significant Type: Maintenance Work required to maintain or clean up the code labels Jun 25, 2020
@maxsharabayko maxsharabayko added this to the v1.5.0 - Sprint 19 milestone Jun 26, 2020
@ethouris ethouris mentioned this pull request Jun 26, 2020
Closed
@ethouris ethouris added this to Backlog in Development via automation Jun 30, 2020
@ethouris ethouris mentioned this pull request Jul 2, 2020
Merged
@maxsharabayko maxsharabayko modified the milestones: v1.5.0 - Sprint 19, v1.5.0 - Sprint 20 Jul 27, 2020
maxsharabayko
maxsharabayko reviewed Jul 28, 2020
View reviewed changes
srtcore/api.cpp Outdated Show resolved Hide resolved
srtcore/api.cpp Outdated Show resolved Hide resolved
@mbakholdina mbakholdina modified the milestones: v1.5.0 - Sprint 20, v1.5.0 - Sprint 21 Aug 10, 2020
@ethouris ethouris marked this pull request as ready for review August 11, 2020 15:25
@ethouris ethouris added Impact: Low and removed Impact: Significant [build] Area: Changes in build files labels Aug 11, 2020
@ethouris ethouris moved this from Backlog to Needs Review in Development Aug 11, 2020
@maxsharabayko maxsharabayko merged commit 19f8b80 into Haivision:master Aug 11, 2020
Development automation moved this from Needs Review to Done Aug 11, 2020
@ethouris ethouris deleted the dev-rework-sync-eh branch August 12, 2020 08:04
@mbakholdina mbakholdina removed this from the v1.5.0 - Sprint 21 milestone Oct 14, 2020
@mbakholdina mbakholdina added this to the v1.4.2 milestone Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsharabayko maxsharabayko maxsharabayko left review comments

Assignees

@ethouris ethouris

Labels
[core] Area: Changes in SRT library core Priority: Medium Type: Maintenance Work required to maintain or clean up the code
Projects
No open projects
Development
  
Done
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.

Completion of error handling
3 participants
@ethouris @maxsharabayko @mbakholdina