Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed default binding for IPv6-target rendezvous. Updated documentation. #1381

Merged
merged 4 commits into from Aug 5, 2020
Merged

Fixed default binding for IPv6-target rendezvous. Updated documentation. #1381

merged 4 commits into from Aug 5, 2020

Conversation

ethouris
Copy link
Collaborator

Fixes #1377

Changes added:

  1. The applications use the same IPv4/6 family in rendezvous mode as the target address, in case when adapter is not specified.
  2. Added lacking check for same family for the target address, in case when the socket is already bound. This is a fix required after introducing "family independent sockets" - this fix wasn't previously necessary because the family was predefined and therefore the check was done in the beginning for the target address. This check however had to be removed for family independent sockets, as it would be wrong in this context.
  3. Updated information about IPv6 support in the srt-live-transmit application.

@ethouris ethouris self-assigned this Jun 26, 2020
@ethouris ethouris added [apps] Area: Test applications related improvements [core] Area: Changes in SRT library core [docs] Area: Improvements or additions to documentation Impact: Significant Priority: Medium Type: Bug Indicates an unexpected problem or unintended behavior labels Jun 26, 2020
@ethouris ethouris added this to Backlog in Development via automation Jun 26, 2020
@ethouris ethouris moved this from Backlog to Needs Review in Development Jun 26, 2020
@ethouris ethouris added this to the v1.5.0 - Sprint 18 milestone Jun 26, 2020
@ethouris
Copy link
Collaborator Author

CodeFactor: complex code - to be ignored.

@maxsharabayko maxsharabayko modified the milestones: v1.5.0 - Sprint 18, v1.5.0 - Sprint 19 Jul 14, 2020
@ethouris ethouris mentioned this pull request Jul 27, 2020
Closed
@maxsharabayko maxsharabayko modified the milestones: v1.5.0 - Sprint 19, v1.5.0 - Sprint 20 Jul 27, 2020
stevomatthews
stevomatthews reviewed Jul 30, 2020
View reviewed changes
Copy link
Collaborator

@stevomatthews stevomatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits

@ethouris @stevomatthews
Apply suggestions from code review
f429bdb 
Documentation review followup

Co-authored-by: stevomatthews <smatthews@haivision.com>
stevomatthews
stevomatthews approved these changes Jul 30, 2020
View reviewed changes
Copy link
Collaborator

@stevomatthews stevomatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor edits

@maxsharabayko maxsharabayko merged commit 5ac3c0c into Haivision:master Aug 5, 2020
Development automation moved this from Needs Review to Done Aug 5, 2020
@mbakholdina mbakholdina removed this from the v1.5.0 - Sprint 20 milestone Oct 14, 2020
@mbakholdina mbakholdina added this to the v1.4.2 milestone Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevomatthews stevomatthews stevomatthews approved these changes

@maxsharabayko maxsharabayko Awaiting requested review from maxsharabayko

Assignees

@ethouris ethouris

Labels
[apps] Area: Test applications related improvements [core] Area: Changes in SRT library core [docs] Area: Improvements or additions to documentation Priority: Medium Type: Bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Development
  
Done
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.

[BUG] srt-live-transmit mode rendezvous not working on IPv6 [apps]
4 participants
@ethouris @stevomatthews @maxsharabayko @mbakholdina