Fixed removing sockets from group members' rolled list after parallelly closed. #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
[core]
|
CodeFactor: complex code - to be ignored. |
|
Fixes #1432? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the sockets weren't removed from the roll list and could make the EID empty without noticing it. Two fixes:
Checking if all sockets from the list after applying a lock for group if they exist and are not broken. If not pass this test, remove them ALSO from the list of sockets to review. If this makes the container empty, the loop will interrupt at the next iteration.
Checking the return code from
srt_epoll_waitcall. It could have happened that it returns error in case when EID container is empty, which should be handled. No other error than that is predicted to happen; the error log is displayed in case when it would happen.Removal from the EID container immediately when found out that the socket is broken so that this doesn't get probed again in this loop.