Define OSX if TARGET_OS_OSX for convenience

[oviano]

It's convenient when not using the CMAKE system for platform_sys.h to define OSX when TARGET_OS_OSX is defined, to avoid having to define OSX, which really shouldn't be necessary.

[maxsharabayko]

A TODO note: consider #1243.

[oviano]

A TODO note: consider #1243.

I just had a look at that, the suggestion seems to be to use the CMAKE_SYSTEM_NAME variable throughout. That strikes me as inferior to using the standard Apple definitions that are defined in TargetConditionals.h and which most of the code is already including via platform_sys.h.

Best solution, IMO would be to:

1. make sure TargetConditionals.h is always included, via platform_sys.h. This is mostly the case, but I noticed as part of my other PR that some files don't include platform_sys.h.

2. use TARGET_OS_OSX along with TARGET_OS_IOS and TARGET_OS_TV. This is standard in Apple world.

Otherwise you've got to basically define "CMAKE_SYSTEM_NAME" if you are using this code but not using the CMAKE system.

If that is not a valid use case then fair enough, bit it seems a little back-to-front to me....

[oviano]

Ok, I updated the PR with what in my view is the proper solution, but it's entirely up to you guys if you take it 👍

[maxsharabayko]

Maybe a single TARGET_OS_MAC instead of the three TARGET_OS_IOS, TARGE_OS_OSX and TARGET_OS_TV would work... 🤔
Target Conditionals

  +----------------------------------------------------------------+
  |                TARGET_OS_MAC                                   |
  | +---+  +-----------------------------------------------------+ |
  | |   |  |          TARGET_OS_IPHONE                           | |
  | |OSX|  | +-----+ +----+ +-------+ +--------+ +-------------+ | |
  | |   |  | | IOS | | TV | | WATCH | | BRIDGE | | MACCATALYST | | |
  | |   |  | +-----+ +----+ +-------+ +--------+ +-------------+ | |
  | +---+  +-----------------------------------------------------+ |
  +----------------------------------------------------------------+

[oviano]

That makes sense, I've updated the PR.

[maxsharabayko]

Sorry, one more suggestion, given that we are looking at these definitions. 🙂

Comparing TARGET_OS_MAC with 1 can be improved in the following way.

For example:

#elif (TARGET_OS_MAC == 1)

can be

#elif TARGET_OS_MAC

Another example condition:

#elif defined(BSD) || TARGET_OS_MAC

[maxsharabayko]

Thank you for your input, @oviano!