Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Added non-blocking option for bonding examples #1746

Merged

Conversation

ethouris
Copy link
Collaborator

This adds a possibility of using non-blocking mode in bonding examples, when last argument is n.

@ethouris ethouris added Priority: High Type: Enhancement Indicates new feature requests [apps] Area: Test applications related improvements labels Jan 15, 2021
@ethouris ethouris added this to the v1.4.3 milestone Jan 15, 2021
Copy link
Collaborator

@maxsharabayko maxsharabayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples are now looking very complicated to read.
Consider moving some logic to a dedicated function like ConnectCaller(..), SendDummyPayload(..) or similar.

@maxsharabayko maxsharabayko changed the title [MAINT] Added non-blocking option for bonding tests [MAINT] Added non-blocking option for bonding examples Jan 21, 2021
@maxsharabayko maxsharabayko merged commit 5066569 into Haivision:master Jan 21, 2021
@nobodyintheworld
Copy link

in https://github.com/Haivision/srt/blob/master/examples/example-client-nonblock.c
srt_setsockflag(ss, SRTO_RCVSYN, &yes, sizeof yes)
here yes is 1 (according to doc api, this is blocking mode ) why the file name is "client-nonblock.c" ??

@maxsharabayko
Copy link
Collaborator

@nobodyintheworld It was a mistake. Thanks for finding and reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[apps] Area: Test applications related improvements Priority: High Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants