[core] Fixed packet drop when reading from members #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSBPD thread of a member socket might not yet trigger epoll read-ready event, while it is potentially ready. If another member signals read-readiness ahead of the current position it will result in a packet drop by a group.
maxsharabayko
added
Type: Bug
ethouris
reviewed
Feb 3, 2021
|
Changed |
|
30 test runs, no losses 👍 Receiver-caller srt-xtransmit receive "srt://192.168.1.91:4200?grouptype=backup&weight=75&latency=800"
"srt://192.168.1.91:4201?weight=25" --statsfile backup-stats-rcv.csv --statsfreq 1s --enable-metricsSender-listener srt-xtransmit generate srt://:4200 srt://:4201 --sendrate 500kbps --duration 5s --enable-metrics --reconnect -v
|
ethouris
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSBPD thread of a group member might not yet trigger epoll read-ready event, while it is potentially ready.
If another member signals read-readiness ahead of the current position it will result in a packet drop by a group.
This PR changes the logic of a group waiting for read-readiness.
When a notification is received, not only notified sockets are added to the reading list, but also those not notified, but with receiver buffer ready to read.
Fixes #1755
Fixes: #1757 (likely the same reason, tests show no losses when switching back)