Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SRTO_CONNTIMEO restrict #1864

Merged
merged 6 commits into from Mar 18, 2021
Merged

Fix SRTO_CONNTIMEO restrict #1864

merged 6 commits into from Mar 18, 2021

Conversation

quink-black
Copy link
Contributor

No description provided.

@maxsharabayko maxsharabayko added the [core] Area: Changes in SRT library core label Mar 15, 2021
@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Mar 15, 2021
@maxsharabayko
Copy link
Collaborator

A note for further review (for myself later):
conntimeo URI query option (application level) is already marked as PRE.
See SocketOption srt_options.

@maxsharabayko
Copy link
Collaborator

Resolved merge conflict with the latest master. SrtOptionAction structure was moved a bit above in PR #1868.

@maxsharabayko
Copy link
Collaborator

TestConnectionTimeout.Nonblocking and TestConnectionTimeout.BlockingLoop are passing.
Added timeout check to TestConnectionTimeout.BlockingLoop to also verify the actual timeout is around the target.

@maxsharabayko
TestConnectionTimeout.BlockingLoop: increased tolerance to 200ms
7a95ba1 
GitHub CI (macOS) gives up to 141ms delay.
@maxsharabayko maxsharabayko merged commit b38bb7f into Haivision:master Mar 18, 2021
@maxsharabayko maxsharabayko mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quink-black @maxsharabayko