Use the Mersenne Twister engine when C++11 is available #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Maintenance
maxsharabayko
changed the title
instead of the std::random_device. Fixed max value probability for the default (C++03) rand().
maxsharabayko
force-pushed
the
develop/rand_mersenne_twister
branch
from
767cceb
to
18ff26e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Mersenne Twister engine if
ENABLE_CXX=ONinstead of arandom_devicedirectly.std::random_deviceis usually slower and may be deterministic. E.g. see this for more details.An example run of the
SyncRandom.GenRandomIntunit test generating 4560000 samples took 72 ms withrandom_deviceinstead of 54 ms withmt19937.