Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test][MAINT] Splitting ListenCallback test into 3 separate tests, fixed proper setup/teardown #2556

Merged

Conversation

ethouris
Copy link
Collaborator

Fixes #1306

@ethouris ethouris added Type: Maintenance Work required to maintain or clean up the code [tests] Area: Unit tests labels Nov 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2556 (ec3c6c3) into master (6d62096) will decrease coverage by 0.09%.
The diff coverage is 96.00%.

@@            Coverage Diff             @@
##           master    #2556      +/-   ##
==========================================
- Coverage   65.95%   65.85%   -0.10%     
==========================================
  Files         100      100              
  Lines       19777    19841      +64     
==========================================
+ Hits        13043    13066      +23     
- Misses       6734     6775      +41     
Impacted Files Coverage Δ
test/test_listen_callback.cpp 68.79% <96.00%> (-19.52%) ⬇️
srtcore/list.cpp 79.13% <0.00%> (-2.99%) ⬇️
srtcore/buffer_snd.cpp 67.10% <0.00%> (-0.66%) ⬇️
test/test_bonding.cpp 97.89% <0.00%> (-0.53%) ⬇️
srtcore/core.cpp 59.90% <0.00%> (-0.17%) ⬇️
srtcore/api.cpp 53.28% <0.00%> (+0.05%) ⬆️
srtcore/congctl.cpp 81.86% <0.00%> (+1.03%) ⬆️
srtcore/queue.cpp 81.00% <0.00%> (+1.18%) ⬆️
srtcore/cache.h 83.07% <0.00%> (+3.07%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Nov 28, 2022
@maxsharabayko maxsharabayko merged commit 053f179 into Haivision:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[tests] Area: Unit tests Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tests] Split listener callback test into three test cases
3 participants