Do not expose internals unneeded by the external API #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… export global symbols in the SRT library with names like gettimeofday, clock_gettime, and timeradd as these are standard symbol names that may clash with the library user. This PR makes them static implementations to the library for internal use only and does not expose them to the public include and API.
…inline C functions. static inline C is a C99 feature and MVC does not support C99.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not expose internals unneeded by the external API. Also do not export global symbols in the SRT library with names like gettimeofday, clock_gettime, and timeradd as these are standard symbol names that may clash for the library user. This PR makes them static implementations to the library for internal use only and does not expose them to the public include and API. This also removes the wintime.h from the public API which may also, unnessarily cause clashes for the external library user.