Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevented 0 pktsInFlight to be used in calculation for loss percentage #888

Merged
merged 1 commit into from Oct 4, 2019

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Sep 26, 2019

Fixes #887

pktsInFlight could be 0, and when so, the division by this without checking led to crash

@ethouris ethouris added this to Needs review in Development via automation Sep 26, 2019
@ethouris ethouris added this to the v1.4.1 milestone Sep 26, 2019
@ethouris ethouris added [core] Area: Changes in SRT library core Priority: Critical Status: Review Needed Type: Bug Indicates an unexpected problem or unintended behavior labels Sep 26, 2019
Development automation moved this from Needs review to Reviewer approved Oct 4, 2019
@rndi rndi merged commit ef8ba13 into Haivision:master Oct 4, 2019
Development automation moved this from Reviewer approved to Done Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Priority: Critical Type: Bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

Floating point exception in slowdownSndPeriod() with Ubuntu NetEm tool
3 participants