Fixed in FEC crash when a large number of dropped packets occur causi… #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng celloff to become negative and therefore accessing out of bounds for rcv.cells deque. This crash can be reproduced by putting Clumsy.exe (Dropped packet / latency simulator) between two machines and turning on lag (200ms will do it) and then turning it off, this causes a consistent crash of SRT.
ethouris
reviewed
Sep 30, 2019
srtcore/fec.cpp
Outdated
| @@ -696,7 +696,7 @@ bool FECFilterBuiltin::receive(const CPacket& rpkt, loss_seqs_t& loss_seqs) | |||
| // be simultaneously also retransmitted. This may confuse the tables. | |||
| int celloff = CSeqNo::seqoff(rcv.cell_base, rpkt.getSeqNo()); | |||
| bool past = celloff < 0; | |||
| bool exists = celloff < int(rcv.cells.size()) && rcv.cells[celloff]; | |||
| bool exists = celloff < int(rcv.cells.size()) && celloff >= 0 && rcv.cells[celloff]; | |||
There was a problem hiding this comment.
I'd change it to !past as the first condition in the definition of exists. At least it makes it more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng celloff to become negative and therefore accessing out of bounds for rcv.cells deque. This crash can be reproduced by putting Clumsy.exe (Dropped packet / latency simulator) between two machines and turning on lag (200ms will do it) and then turning it off, this causes a consistent crash of SRT.
Following this, SRT does not recover it outputs the following errors:
17:04:49.149217E:SRT.c: FEC/V: OFFSET=22 exceeds maximum col container size, SHRINKING container by 10
17:04:49.149331E:SRT.c: FEC/V: IPE: removal of 10 rows ships no same seq: rowbase=%2098878350 colbase=%2098878250 -> %2098878058 - RESETTING ROWS
OR:
17:28:48.626315E:SRT.c: FEC/V: OFFSET=29 exceeds maximum col container size, SHRINKING container by 10
17:28:48.626404E:SRT.c: FEC/V: IPE: removal of 10 rows ships no same seq: rowbase=%601155798 colbase=%601155698 -> %601155504 - RESETTING ROWS
Where it gets into an non working state.