[core] Use busy wait only to refine below 1 ms. #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use high accuracy busy waiting to wait only the remaining 1 ms (10 ms on Windows) of the waiting time. Reduces idle CPU from around 20% to almost zero on Windows machines at low bitrates.
maxsharabayko
added
Type: Maintenance
from m_ullSchedTime. And names of some other variables as well.
ethouris
approved these changes
Nov 4, 2019
rndi
reviewed
Nov 4, 2019
| #endif | ||
|
|
||
| timeval now; | ||
| gettimeofday(&now, 0); |
There was a problem hiding this comment.
Please use monotonic clock when ENABLE_MONOTONIC_CLOCK is defined.
There was a problem hiding this comment.
for self-reference, PR #929 reworks this code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use high accuracy busy waiting to wait only the remaining 1 ms (10 ms on Windows) of the waiting time.
Reduces idle CPU from around 20% to almost zero on Windows machines at low bitrates.
The solution is taken from #673, proposed by @oviano.