Include both 32 bit and 64 bit runtimes in .NET Framework builds #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was an issue with the Github build actions, which are fixed in master now. Can you please rebase and update your PR so we can make sure it builds fine before I merge? |
mathlang
force-pushed
the
NetFrameworkDependencies
branch
from
c437f05
to
bf0f78b
Compare
HakanL
approved these changes
Nov 24, 2021
|
@mathlang Thanks for this commit, I think this fixed the issue with the dll in the root as well. I've added some test projects as well to the main solution to test the various platforms, after this PR it looks pretty good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the build process to copy both x86 and x64 runtimes when building .NET Framework projects. Having only the x86 DLL linked in the project root does not work for AnyCPU assemblies that can run in both 32 bit and 64 bit and needs the proper version of the DLL.
Instead the runtimes folder is copied with only win-x86 and win-x64 runtimes (the others platforms are not supported by .NET Framework)
I believe this will fix issue #58