Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the home page for React application #106

Closed
sarthakkundra opened this issue Aug 27, 2020 · 11 comments
Closed

Create the home page for React application #106

sarthakkundra opened this issue Aug 27, 2020 · 11 comments

Comments

@sarthakkundra
Copy link
Collaborator

Type

New feature ( User Interface )

Description

The React app has a pages sub-folder where all the pages will go.
Make the home page as per the approved UI.

Note You don't need to make the navbar as that is a separate component and that work has been assigned to someone.

Tools

JSX
HTML
Bootstrap (react-bootstrap)

Have you read the Contributing Guidelines on Pull Requests?

Yes.

@nooras
Copy link
Contributor

nooras commented Aug 29, 2020

Hey i wanted to try this... can You assign me? as i am new to React... I want to work on this... @sarthakkundra
And 1 more where is UI?

@sarthakkundra
Copy link
Collaborator Author

@nooras You have 7 days to work on this issue. Make a folder called 'pages' inside of components and make a file called HomePage.js and work in it. The approved UI was sent to the Slack channel, it might be available somewhere in the repo also.

@nooras
Copy link
Contributor

nooras commented Aug 29, 2020

Okay sir got it ... @sarthakkundra

@sarthakkundra
Copy link
Collaborator Author

@nooras It's a React page so you won't need a separate HTML file. Are you sure you want to do this, this is a bit advanced work

@nooras
Copy link
Contributor

nooras commented Aug 29, 2020

Yes yess

@sarthakkundra
Copy link
Collaborator Author

@nooras All the best! :) Feel free to ask for help here if you're stuck

@nooras
Copy link
Contributor

nooras commented Sep 3, 2020

Home page done @sarthakkundra

home

@github-actions
Copy link

This issue is labelled as stale because it has been open for more than 7 days with no activity.

@github-actions github-actions bot added the Stale label Sep 23, 2020
@nooras
Copy link
Contributor

nooras commented Sep 23, 2020

Do close this issue... Work is already done and merged #129 @sarthakkundra

@sarthakkundra
Copy link
Collaborator Author

@nooras this is a PR not an issue and we've merged the restyled PR so you can go ahead and delete it.

@nooras
Copy link
Contributor

nooras commented Sep 23, 2020

I mean to say this (Current issue page on which we commenting each other) #106 ..... 😅 @sarthakkundra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants