-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the home page for React application #106
Comments
Hey i wanted to try this... can You assign me? as i am new to React... I want to work on this... @sarthakkundra |
@nooras You have 7 days to work on this issue. Make a folder called 'pages' inside of components and make a file called HomePage.js and work in it. The approved UI was sent to the Slack channel, it might be available somewhere in the repo also. |
Okay sir got it ... @sarthakkundra |
@nooras It's a React page so you won't need a separate HTML file. Are you sure you want to do this, this is a bit advanced work |
Yes yess |
@nooras All the best! :) Feel free to ask for help here if you're stuck |
Home page done @sarthakkundra |
This issue is labelled as stale because it has been open for more than 7 days with no activity. |
Do close this issue... Work is already done and merged #129 @sarthakkundra |
@nooras this is a PR not an issue and we've merged the restyled PR so you can go ahead and delete it. |
I mean to say this (Current issue page on which we commenting each other) #106 ..... 😅 @sarthakkundra |
Type
New feature ( User Interface )
Description
The React app has a pages sub-folder where all the pages will go.
Make the home page as per the approved UI.
Note You don't need to make the navbar as that is a separate component and that work has been assigned to someone.
Tools
JSX
HTML
Bootstrap (react-bootstrap)
Have you read the Contributing Guidelines on Pull Requests?
Yes.
The text was updated successfully, but these errors were encountered: