Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample config is outdated #510

Open
spantaleev opened this issue Jun 26, 2019 · 2 comments
Open

Sample config is outdated #510

spantaleev opened this issue Jun 26, 2019 · 2 comments
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@spantaleev
Copy link

The sample config (config/config.sample.yaml) lists userStorePath and roomStorePath, but they no longer seem to be in use.

Starting the bridge with them provided leads to the following warnings:

[DiscordAS] warn: [DEPRECATED] The room store is now part of the SQL database.The config option roomStorePath no longer has any use.
[DiscordAS] warn: [DEPRECATED] The user store is now part of the SQL database.The config option userStorePath no longer has any use

I wonder if there are other unnecessary things in the sample config.. or if there are new and useful things which are omitted.
@spantaleev
Copy link
Author

The README also mentions userStorePath and roomStorePath.

@spantaleev spantaleev mentioned this issue Jun 26, 2019
Open
spantaleev added a commit to spantaleev/matrix-docker-ansible-deploy that referenced this issue Aug 1, 2019
@spantaleev
Add missing required parameters for Discord bridge
524436e 
Fixes #230 (Github Issue).

Related to matrix-org/matrix-appservice-discord#510
@spantaleev
Copy link
Author

This seems worse than a documentation problem, as described in spantaleev/matrix-docker-ansible-deploy#230

Starting the bridge with userStorePath and userStorePath provided makes the bridge complain (as mentioned above).

Starting it without these parameters makes it die with an error.

It's confusing..

microchipster pushed a commit to microchipster/matrix-docker-ansible-deploy that referenced this issue Aug 3, 2019
@spantaleev @microchipster
Add missing required parameters for Discord bridge
20f90d2 
Fixes spantaleev#230 (Github Issue).

Related to matrix-org/matrix-appservice-discord#510
@Half-Shot Half-Shot added this to the 0.6.0 milestone Aug 20, 2019
@Half-Shot Half-Shot added T-Documentation Improvements or additions to documentation T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. and removed T-Documentation Improvements or additions to documentation documentation labels May 16, 2022
@Half-Shot Half-Shot removed this from the 0.6.0 milestone May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spantaleev @Half-Shot