Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord -> Matrix: Gif feature should result in image, not link #762

Open
tgr opened this issue Dec 29, 2021 · 7 comments
Open

Discord -> Matrix: Gif feature should result in image, not link #762

tgr opened this issue Dec 29, 2021 · 7 comments
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements.

Comments

@tgr
Copy link

tgr commented Dec 29, 2021

When using the "Gif" feature in Discord:
matrix (2)
it results in some image:
matrix (3)
but on the Matrix side it's shared as a link:
Element-Magyar-Wikipédia-Discord-tesztszoba (3)

@sagehane
Copy link

I personally prefer the status quo. I feel like converting links to images should be left up to url previews (and I personally like to disable url previews).

Images are also more costly to send than mere links.

@tgr
Copy link
Author

tgr commented Jan 10, 2022

IMO the bridge's job should be to translate messages with a look and behavior as close to the original as possible, to avoid creating disconnects between the two groups of users. Transforming them into something different that's more convenient for the user is the job of the client.

@sagehane
Copy link

Transforming them into something different that's more convenient for the user is the job of the client.

By that logic, shouldn't it be the client's job to enable url previews by default or not? How can the client transform it to something more convenient? Is the client expected to reverse image search every image it receives and ask the users if they would want to convert it to a matching url?

Your proposal does indeed make the "look" from Discord -> Matrix close to the original as possible, but as far as "behavior" goes, it would be quite different. It also causes inconsistencies.

Discord -> Matrix would create a seemingly unnecessary image for Matrix, which fails to replicate the behavior.
Sending the url from Matrix -> Discord would cause the same problem you outlined but in reverse (link shown on Matrix's side, image on Discord), and there would be no sane way to fix that without relying on url previews anyways.

The only workaround I can imagine to that is to expect Matrix users to never send links and send images instead, but that would also end up sending an image to Discord when a link would have sufficed for them. That would just introduce another disparity in behavior.

I don't think your proposal makes sense in terms of consistent behavior between both sides of the bridge.

@Miepee
Copy link
Contributor

Miepee commented Mar 31, 2022

I personally disagree with this change as well.
Discord also does have an option to disable URL previews (Settings -> Text & Images). Which would make this even more inconsistent.
With URL preview:
image
Without:
image

So by forcing to always send Gifs as images this would just cause even more inconsistencies and force Matrix users to see an image, where Discord users don't necessarily see one.

@hazycora
Copy link

hazycora commented Apr 8, 2022

just have it be an option? in the settings?

@Miepee
Copy link
Contributor

Miepee commented Apr 8, 2022

nobody sees the gifs on the matrix end

That really depends on the client you're using.
They're fine with Element Desktop (I can get the full playing GIF when i click on the preview image)
image
and look good on Element mobile and even animate there
image

If you want the Embed behaviour to change for tenor, this probably should be brought up in the client you're using.

@hazycora
Copy link

hazycora commented Apr 8, 2022

I am on element mobile, latest version too. my friends don't see gif previews either and they're all on different homeservers, so I don't know how we all aren't seeing gif previews lol

@jaller94 jaller94 added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements. label May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements.
Projects
None yet
Development

No branches or pull requests

5 participants