New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k_nearest_neighbor.py #1

Merged

Halfish merged 2 commits into Halfish:master from Ja1r0:patch-1

Dec 26, 2017

Contributor

Ja1r0 commented Dec 20, 2017

In the no loop situation,the square root is missing when compute the L2 distance.


          Update k_nearest_neighbor.py

ef9d37f

In the no loop situation,the square root is missing when compute the L2 distance.

Owner

Halfish commented Dec 21, 2017

hi，@Ja1r0，这个加上平方根确实是正确的，同时 one_loop 和 no_loop 也是需要一样的做法；不过改不改应该都不影响 kNN 最后的结果，因为开平方操作是单调递增函数，不影响排序。


          Update k_nearest_neighbor.py

4e4e833

Halfish merged commit d355c0c into Halfish:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment