adb daemon: Don't drop privileges

[fredldotme]

Running adbd as root via the 'adb root' command causes
adbd to stop and not respawn, so avoid dropping
privileges altogether in favor of running as root.

[Vince1171]

@fredldotme do you know if htere is any reason why this haven't been merged yet?

[fredldotme]

@fredldotme do you know if htere is any reason why this haven't been merged yet?

It effectively is a hack, considering that it completely invalidates the ability to build adb-capable and adb-incapable builds by just switching the breakfast target between userdebug and user.

[Vince1171]

@fredldotme do you know if htere is any reason why this haven't been merged yet?

It effectively is a hack, considering that it completely invalidates the ability to build adb-capable and adb-incapable builds by just switching the breakfast target between userdebug and user.

mmmh so it's not a problem from UT but it could be for other OS?

[fredldotme]

@fredldotme do you know if htere is any reason why this haven't been merged yet?

It effectively is a hack, considering that it completely invalidates the ability to build adb-capable and adb-incapable builds by just switching the breakfast target between userdebug and user.

mmmh so it's not a problem from UT but it could be for other OS?

It's a problem especially on UT as it does build both breakfast targets and expecting different behaviors. Effectively the change needs to made such that the privilege dropping happens again on user builds.

[Vince1171]

So we still need it (as it's shipped with most halium 7.1 UT devices) but shouldn't use it?