Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a way to mark older non Expanded cards with new reprints as legal #14

Closed
Hamatti opened this issue Nov 12, 2022 · 3 comments · Fixed by #15
Closed

Figure out a way to mark older non Expanded cards with new reprints as legal #14

Hamatti opened this issue Nov 12, 2022 · 3 comments · Fixed by #15

Comments

@Hamatti
Copy link
Owner

Hamatti commented Nov 12, 2022

Currently there's one subset of cards that are not correctly identified. Cards like Switch HS 102 are legal but the tool marks them as invalid because they are from sets not marked legal.

Since the oldest sets in PTCGO are Heart Gold & Soul Silver onwards, it might be possible to make a list of those cards by hand, if there's no way to automatically deduce that information from the data.

@Hamatti
Copy link
Owner Author

Hamatti commented Nov 12, 2022

With the example cards Switch HS 102:

In the API, the set is marked for legality of Unlimited but the card itself is marked legal for Unlimited, Expanded and Standard.

So there is data for that, I just need to adjust the code to include cards from those sets that are expanded legal.

@Hamatti
Copy link
Owner Author

Hamatti commented Nov 12, 2022

Make a new faux set with the following:

https://api.pokemontcg.io/v2/cards?q=set.ptcgoCode:HS%20legalities.expanded:legal (= 20 cards)
https://api.pokemontcg.io/v2/cards?q=set.ptcgoCode:CL%20legalities.expanded:legal (= 10 cards)
https://api.pokemontcg.io/v2/cards?q=set.ptcgoCode:UL%20legalities.expanded:legal (= 4 cards)

(the other HGSS sets don't have legal cards)

@Hamatti
Copy link
Owner Author

Hamatti commented Nov 12, 2022

Turns out, all I had to do was download those sets and add a small extra case for validation print for those three special cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant