Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update menus.json #7

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Conversation

DDinghoya
Copy link
Contributor

@DDinghoya DDinghoya commented Dec 11, 2022

And, When I thought about it, Directory name is wrong by HOS localizations.

locale

Directory rename from "kr-KO" to "ko", Can you change it to "ko"?

Or should I delete the directory and create a new one?

And, When I thought about it, Directory name is wrong by HOS localizations.

Directory rename from "kr-KO" to "ko", Can you change it to "ko"?

Or should I delete the directory and create a new one?
@HamletDuFromage
Copy link
Owner

Does it not currently work?
Borealis expects ko (https://github.com/natinusala/borealis/wiki/Internationalization-system). If you get the app in Korean then I wouldn't change anything

@DDinghoya
Copy link
Contributor Author

Does it not currently work? Borealis expects ko (https://github.com/natinusala/borealis/wiki/Internationalization-system). If you get the app in Korean then I wouldn't change anything

I thought about it because I couldn't apply Korean until now.

nxlocaleswitcher

Of course, I thought in addition to the reason for the missing quotation marks.

I hope this FR solves it well.

@DDinghoya
Copy link
Contributor Author

DDinghoya commented Dec 12, 2022

Does it not currently work? Borealis expects ko (https://github.com/natinusala/borealis/wiki/Internationalization-system). If you get the app in Korean then I wouldn't change anything

It was confirmed that the Korean language was output normally only when the directory was converted to "ko" as below;

nxlocaleswitch_1

Would you please change from "kr-KO" to "ko"?

@HamletDuFromage
Copy link
Owner

oh sorry I misread you, I thought that you wanted to change from ko to kr-KO, not that what you wrote was in kr-KO

@HamletDuFromage HamletDuFromage merged commit b895bc1 into HamletDuFromage:master Dec 12, 2022
@DDinghoya
Copy link
Contributor Author

oh sorry I misread you, I thought that you wanted to change from ko to kr-KO, not that what you wrote was in kr-KO

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants