Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC Compile broken on pthreads.h include #1107

Closed
mdblack98 opened this issue Aug 26, 2022 · 1 comment
Closed

MSVC Compile broken on pthreads.h include #1107

mdblack98 opened this issue Aug 26, 2022 · 1 comment
Labels
bug build critical A problem for common operations with WSJT-X, GPredict, RigPi, etc. fixed Issue has been fixed
Milestone
4.5

Comments

@mdblack98
Copy link
Contributor

MSVC compile fails on latest hamlib as MSVC does not have pthreads.h
@mdblack98 mdblack98 added bug critical A problem for common operations with WSJT-X, GPredict, RigPi, etc. build labels Aug 26, 2022
@mdblack98 mdblack98 added this to the 4.5 milestone Aug 26, 2022
mdblack98 added a commit that referenced this issue Aug 26, 2022
@mdblack98
Add winpthreads.h -- not sure if this will actually work in MSVC comp…
7c071b8 
…iliaton for true threading support.

But at least it let's it compile and satisfied the pthread calls.
For standalone apps threading is not currently used although pthread mutex calls are used.
#1107
@mdblack98 mdblack98 added needs test Patches have been submitted but need testing to close issue and removed needs test Patches have been submitted but need testing to close issue labels Aug 26, 2022
@mdblack98
Copy link
Contributor Author

MSVC compile now working.
But winpthreads.h has static items which need to be in winpthreads.c instead of winpthreads.h otherwise cannot link multiple compilation units referencing rig.h

mdblack98 added a commit that referenced this issue Sep 3, 2022
@mdblack98
Remove winpthreads.h
1d0d733 
MSVC build now needs NuGet pthreads package to compile
#1107
@mdblack98 mdblack98 added needs test Patches have been submitted but need testing to close issue fixed Issue has been fixed and removed needs test Patches have been submitted but need testing to close issue labels Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug build critical A problem for common operations with WSJT-X, GPredict, RigPi, etc. fixed Issue has been fixed
Projects
None yet
Milestone
4.5
Development

No branches or pull requests
1 participant
@mdblack98