Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String data type in XML-RPC incorrectly defined in Hamlib 4.5 #1134

Closed
AG7GN opened this issue Oct 30, 2022 · 3 comments
Closed

String data type in XML-RPC incorrectly defined in Hamlib 4.5 #1134

AG7GN opened this issue Oct 30, 2022 · 3 comments
Labels
bug fixed Issue has been fixed
Milestone

Comments

@AG7GN
Copy link

AG7GN commented Oct 30, 2022

Hamlib 4.5 does not recognize string data type returned via XML-RPC. The reason is that this line in rigs/dummy/flrig.c:

if (streq(p, "i4") || streq(p, "double") || streq(p, "int") || streq(p, " string"))

has an extraneous space in " string". It should be:

if (streq(p, "i4") || streq(p, "double") || streq(p, "int") || streq(p, "string"))

Thanks.

Steve AG7GN

@N0NB
Copy link
Contributor

N0NB commented Oct 31, 2022

Thanks, Steve. Mike, will this require a 4.5.1 bug release soon?

@mdblack98 mdblack98 added the bug label Oct 31, 2022
@mdblack98
Copy link
Contributor

Where is this causing an error?
It does need fixed but FLRig is the only known client for this and I don't know of any errors with that (I use it here)

@mdblack98 mdblack98 added this to the 4.5.1 milestone Oct 31, 2022
@mdblack98 mdblack98 added the fixed Issue has been fixed label Oct 31, 2022
@AG7GN
Copy link
Author

AG7GN commented Oct 31, 2022

Thanks for fixing this. I've written my own flrig-like app for certain Kenwood radios using Python's xmlrpc.server module. That module does not support the nil or i4 data types, but it does support int and string, hence my need for hamlib XML-RPC to support strings.

Steve AG7GN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed Issue has been fixed
Projects
None yet
Development

No branches or pull requests

3 participants