Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotctl model 405 does not return elevation angle from second device #1258

Closed
NUCARADO opened this issue Mar 25, 2023 · 1 comment
Closed
Labels
bug needs test Patches have been submitted but need testing to close issue
Milestone

Comments

@NUCARADO
Copy link

The Green Heron RT-21 uses two different devices, one for azimuth and one for elevation. Support for the elevation device appears to be incomplete. Elevation value is never queried on the second device.

Rotator command: p
rot_get_position called
rt21_rot_get_position called
rotorez_send_priv_cmd called
write_block(): TX 4 bytes, method=2
0000 42 49 31 3b BI1;
read_string_generic called, rxmax=7 direct=1, expected_len=1
read_string_generic(): RX 5 characters, direct=1
0000 32 30 2e 30 3b 20.0;
rt21_rot_get_position: "20.0;" after conversion = 20.0
rt21_rot_get_position: azimuth = 20.0 deg; elevation = 0.0 deg
rot_get_position: got az=20.00, el=0.00
Azimuth: 20.00
Elevation: 0.00

In Rotorez.c:

elevation = 0.0; / RT-21 backend does not support el at this time. */

@mdblack98 mdblack98 added the bug label Mar 28, 2023
@mdblack98 mdblack98 added this to the 4.5.5 milestone Mar 28, 2023
@mdblack98 mdblack98 modified the milestones: 4.5.5, 4.6 Apr 10, 2023
mdblack98 added a commit that referenced this issue Apr 30, 2023
@mdblack98 mdblack98 added the needs test Patches have been submitted but need testing to close issue label Apr 30, 2023
@mdblack98
Copy link
Contributor

No news is good news I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs test Patches have been submitted but need testing to close issue
Projects
None yet
Development

No branches or pull requests

2 participants