Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cppcheck warnings #1351

Closed
mdblack98 opened this issue Aug 2, 2023 · 1 comment
Closed

Fix cppcheck warnings #1351

mdblack98 opened this issue Aug 2, 2023 · 1 comment
Labels
bug needs test Patches have been submitted but need testing to close issue
Milestone

Comments

@mdblack98
Copy link
Contributor

mplifiers/expert/expert.c:132:16: warning: Uninitialized variable: cmd [uninitvar]
amplifiers/gemini/gemini.c:160:14: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
amplifiers/gemini/gemini.c:171:14: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
amplifiers/gemini/gemini.c:172:14: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
amplifiers/gemini/gemini.c:174:14: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
amplifiers/gemini/gemini.c:190:37: warning: Either the condition '!amp' is redundant or there is possible null pointer dereference: amp. [nullPointerRedundantCheck]
rigs/anytone/anytone.c:248:9: warning: Either the condition 'p==NULL' is redundant or there is possible null pointer dereference: p. [nullPointerRedundantCheck]
rigs/anytone/anytone.c:279:5: warning: Either the condition 'rig==NULL' is redundant or there is possible null pointer dereference: rig. [nullPointerRedundantCheck]
rigs/anytone/anytone.c:367:5: warning: Either the condition 'rig==NULL' is redundant or there is possible null pointer dereference: rig. [nullPointerRedundantCheck]
rigs/anytone/anytone.c:385:5: warning: Either the condition 'rig==NULL' is redundant or there is possible null pointer dereference: rig. [nullPointerRedundantCheck]
rigs/anytone/anytone.c:439:5: warning: Either the condition 'rig==NULL' is redundant or there is possible null pointer dereference: rig. [nullPointerRedundantCheck]
rigs/anytone/anytone.c:222:5: warning: Either the condition 'rig==NULL' is redundant or there is possible null pointer dereference: rig. [nullPointerRedundantCheck]
rigs/aor/aor.c:274:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
rigs/aor/aor.c:763:13: warning: %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
rigs/aor/ar7030p.c:341:10: warning: Either the condition 'NULL!=rig->state.priv' is redundant or there is possible null pointer dereference: priv. [nullPointerRedundantCheck]
rigs/aor/ar7030p.c:342:10: warning: Either the condition 'NULL!=rig->state.priv' is redundant or there is possible null pointer dereference: priv. [nullPointerRedundantCheck]
rigs/aor/ar7030p.c:344:10: warning: Either the condition 'NULL!=rig->state.priv' is redundant or there is possible null pointer dereference: priv. [nullPointerRedundantCheck]
rigs/codan/codan.c:220:13: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
rigs/dummy/aclog.c:532:17: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
rigs/dummy/aclog.c:585:5: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
rigs/dummy/aclog.c:611:14: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
rigs/dummy/aclog.c:296:20: warning: Uninitialized variable: xml [uninitvar]
rigs/dummy/dummy.c:467:15: warning: Either the condition 'priv' is redundant or there is possible null pointer dereference: priv. [nullPointerRedundantCheck]
rigs/dummy/dummy.c:2186:5: warning: %d in format string (no. 10) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
rigs/dummy/dummy.c:2220:5: warning: %d in format string (no. 10) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
rigs/dummy/dummy.c:465:5: warning: Either the condition 'priv' is redundant or there is possible null pointer dereference: priv. [nullPointerRedundantCheck]
rigs/dummy/netrigctl.c:815:29: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
rigs/dummy/quisk.c:756:29: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
rigs/dummy/rot_dummy.c:172:10: warning: Either the condition 'rot->state.priv' is redundant or there is possible null pointer dereference: priv. [nullPointerRedundantCheck]
rigs/dummy/rot_dummy.c:173:10: warning: Either the condition 'rot->state.priv' is redundant or there is possible null pointer dereference: priv. [nullPointerRedundantCheck]
rigs/dummy/rot_dummy.c:174:10: warning: Either the condition 'rot->state.priv' is redundant or there is possible null pointer dereference: priv. [nullPointerRedundantCheck]
rigs/dummy/rot_dummy.c:175:10: warning: Either the condition 'rot->state.priv' is redundant or there is possible null pointer dereference: priv. [nullPointerRedundantCheck]
rigs/dummy/tci1x.c:623:5: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
rigs/dummy/tci1x.c:636:5: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
rigs/dummy/tci1x.c:671:5: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
rigs/dummy/tci1x.c:823:9: warning: Either the condition '!rig' is redundant or there is possible null pointer dereference: rig. [nullPointerRedundantCheck]
rigs/elad/elad.c:3728:51: warning: Uninitialized variable: idbuf [uninitvar]
rigs/flexradio/dttsp.c:667:5: warning: Either the condition 'rig->state.priv' is redundant or there is possible null pointer dereference: priv. [nullPointerRedundantCheck]
rigs/gomspace/gs100.c:506:9: warning: sscanf() without field width limits can crash with huge input data. [invalidscanf]
rigs/gomspace/gs100.c:105:9: warning: Either the condition '!rig' is redundant or there is possible null pointer dereference: rig. [nullPointerRedundantCheck]
rigs/icom/frame.c:421:6: warning: Either the condition 'data_len!=NULL' is redundant or there is possible null pointer dereference: data_len. [nullPointerRedundantCheck]
rigs/icom/icom.c:739:9: warning: Either the condition '!rig' is redundant or there is possible null pointer dereference: rig. [nullPointerRedundantCheck]

@mdblack98 mdblack98 added the bug label Aug 2, 2023
@mdblack98 mdblack98 added this to the 4.6 milestone Aug 2, 2023
@mdblack98 mdblack98 pinned this issue Oct 1, 2023
mdblack98 added a commit that referenced this issue Oct 1, 2023
mdblack98 added a commit that referenced this issue Oct 1, 2023
mdblack98 added a commit that referenced this issue Oct 1, 2023
mdblack98 added a commit that referenced this issue Oct 1, 2023
@mdblack98 mdblack98 added the needs test Patches have been submitted but need testing to close issue label Oct 2, 2023
mdblack98 added a commit that referenced this issue Oct 4, 2023
mdblack98 added a commit that referenced this issue Oct 4, 2023
mdblack98 added a commit that referenced this issue Oct 6, 2023
mdblack98 added a commit that referenced this issue Oct 9, 2023
mdblack98 added a commit that referenced this issue Oct 9, 2023
@mdblack98 mdblack98 unpinned this issue Nov 10, 2023
@mdblack98
Copy link
Contributor Author

No news is good news I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs test Patches have been submitted but need testing to close issue
Projects
None yet
Development

No branches or pull requests

1 participant