Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement stop_morse for Elecraft K4 #1366

Closed
ny4i opened this issue Aug 18, 2023 · 4 comments
Closed

Enhancement: Implement stop_morse for Elecraft K4 #1366

ny4i opened this issue Aug 18, 2023 · 4 comments
Labels
enhancement needs test Patches have been submitted but need testing to close issue
Milestone

Comments

@ny4i
Copy link

ny4i commented Aug 18, 2023

I am not quite ready yet to create a patch for hamlib but looking at the code, implementing the kenwood_stop_morse but the K4 version would appear to work to stop CW on a K4 (and a K3 if that is not yet implemented). I'm still figuring out how the Kenwood function and the K3/K4 functions work together.

The K3 command KY <ASCII 04> stops the CW immediately on both the K3 and the K4.

mdblack98 added a commit that referenced this issue Aug 18, 2023
@mdblack98 mdblack98 added enhancement needs test Patches have been submitted but need testing to close issue fixed Issue has been fixed and removed fixed Issue has been fixed labels Aug 18, 2023
@ny4i
Copy link
Author

ny4i commented Aug 21, 2023

stop_morse does not seem to be working. I sent bABCDEFGHIJK and then right away sent ,\stop_morse VFOA but the CW did not stop. I then did a test where I did sent ,bABCDEFGHIJK then the next command I sent was ,b@ (where @ is the command in the K4 Programmers Reference that stops CW immediately. That worked.

It appears from the trace that hamlib sends KY1; to stop the morse. That is not a documented way to stop the morse. You would send KY |; or KY @; On the K3, it is \0x04 so KY<hex 04>;

stop_morse-1.txt

mdblack98 added a commit that referenced this issue Aug 21, 2023
@ny4i
Copy link
Author

ny4i commented Aug 21, 2023

I checked the code and there is just one thing missing. You need a space between the KY and the @ or hex 04. That should do it though. I tried to put that that in the above text but I may not have been clear.

mdblack98 added a commit that referenced this issue Aug 21, 2023
@mdblack98 mdblack98 added this to the 4.6 milestone Sep 29, 2023
@mdblack98
Copy link
Contributor

Is this working OK now?

@ny4i
Copy link
Author

ny4i commented Sep 30, 2023

Yes. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs test Patches have been submitted but need testing to close issue
Projects
None yet
Development

No branches or pull requests

2 participants