Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for Hamlib 4.x release #370

Closed
mikaelnousiainen opened this issue Sep 9, 2020 · 8 comments
Closed

Update documentation for Hamlib 4.x release #370

mikaelnousiainen opened this issue Sep 9, 2020 · 8 comments

Comments

@mikaelnousiainen
Copy link
Contributor

mikaelnousiainen commented Sep 9, 2020

Could you update documentation -- mainly header files and man pages -- for at least the following major things that have changed in Hamlib 4.x:

  • set_ant / get_ant function prototypes and man page documentation -- In order to understand how the new parameters (option / antenna), it would be great to have a bit more specific documentation (more text). Additionally rigctld man page doesn't match rigctl man page here. I could even try to update it myself, but even I don't understand how these new parameters should work and what the results should be. A practical example would be very much appreciated.

  • set_channel / get_channel function prototypes and man page documentation -- Currently, it says "not implemented" here. What is the meaning of the new read_only flag?

  • Document any other possible major API changes that I've missed here.

I can also help with the documentation once I understand what the API changes are for and what the intended functionality should be.

@N0NB
Copy link
Contributor

N0NB commented Sep 9, 2020

Hi Mikael.

I have some edits pending on the present man pages. Let me finish them and push them out and then you can jump in.

As for the API changes I think Mike, W9MDB, is the best resource for that information.

As for the roff source, I am trying to follow the man pages project guidelines as much as possible. See man(7) and man-pages(7) as primary guides. Supplemental guides are groff_man(7) and groff_man_style(7).

@N0NB
Copy link
Contributor

N0NB commented Sep 10, 2020

I have pushed my changes out. Jump in, Mikael!

@mikaelnousiainen
Copy link
Contributor Author

Thanks a lot.

@mdblack98 If you could give me some pointers on what intended functionality on the API changes really is, I can proceed to update the docs soon.

@mdblack98
Copy link
Contributor

mdblack98 commented Sep 11, 2020 via email

@mikaelnousiainen
Copy link
Contributor Author

@mdblack98 Ok, thanks! I still have some follow-up questions, however 👍

  1. So just that I understand this correctly, would the RX ant option work like this:
  • \set_ant 3 0 -> Will select antenna 3 as both TX and RX antenna
  • \set_ant 2 1 -> Will select antenna 2 as RX antenna, but keep 3 as TX
  • \set_ant 1 0 -> Will select antenna 1 as both TX and RX antenna, overriding previous RX antenna
  • \set_ant 4 1 -> Will select antenna 4 as RX antenna and now keep 1 as TX antenna?
  1. Also, could you also give me a short description on the read_only flag on \get_channel ? Do some rigs change state when getting channel info?

@mdblack98
Copy link
Contributor

mdblack98 commented Sep 13, 2020 via email

@mikaelnousiainen
Copy link
Contributor Author

mikaelnousiainen commented Sep 14, 2020

Ok, now that 4.0 has not been released yet, I'm wondering if -- instead of adding a parameter to \set_ant and breaking existing applications -- we should add a new command altogether: \set_rx_ant / \get_rx_ant or similar? That would allow the current set_ant functionality to stay as it is and we could experiment with a new command.

Thoughts?

@mdblack98
Copy link
Contributor

mdblack98 commented Sep 14, 2020 via email

mdblack98 added a commit that referenced this issue Sep 17, 2020
N0NB pushed a commit to N0NB/Hamlib that referenced this issue Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants