Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide API calls for functions and values in rig caps and state structures #484

Closed
mdblack98 opened this issue Dec 31, 2020 · 1 comment

Comments

@mdblack98
Copy link
Contributor

mdblack98 commented Dec 31, 2020

WSJT-X and others have had to resort to using rig_caps to get vfo_list, function availability and others to get needed info from hamlib.
Need to implement API calls in 4.X and eventually make these structures private in 5.0

This will avoid shared library problems when structures change.

Support read and set rit
if (myRig->caps->get_rit == nullptr)
if (myRig->caps->set_rit == nullptr)

Whether the radio can set/get vfo
if (myRig->caps->get_vfo == nullptr)
if (myRig->caps->set_vfo == nullptr)

@mdblack98 mdblack98 modified the milestones: 4.1, 5.0 Dec 31, 2020
@mdblack98
Copy link
Contributor Author

mdblack98 commented Jan 1, 2021

Adding
void *rig_get_function_ptr(rig_model_t, enum rig_function_e rig_function);
e.g.
void *p = rig_get_function(rig_model, RIG_FUNCTION_SET_VFO);
same as rig->caps->set_vfo

mdblack98 added a commit that referenced this issue Jan 1, 2021
mdblack98 added a commit that referenced this issue Jan 2, 2021
mdblack98 added a commit that referenced this issue Jan 3, 2021
mdblack98 added a commit that referenced this issue Jan 3, 2021
WSJT-X HamlibTransceiver.cpp now has no dependencies on structure offsets
#484
@mdblack98 mdblack98 modified the milestones: 4.1, 4.2 Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant