C++ warnings

[mdblack98]

Ch. van Wüllen vanwullen@chemie.uni-kl.de
To:
Black Michael

Tue, Mar 9 at 10:58 AM

If one regards C++11 as today’s standard, nothing left to do. Here is the list:

Making all in c++
CXX rigclass.lo
In file included from rigclass.cc:36:
../include/hamlib/rigclass.h:41:23: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rig(const Rig&) = default;
^
../include/hamlib/rigclass.h:42:12: warning: rvalue references are a C++11 extension [-Wc++11-extensions]
Rig(Rig&&) = default;
^
../include/hamlib/rigclass.h:42:18: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rig(Rig&&) = default;
^
../include/hamlib/rigclass.h:43:34: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rig& operator=(const Rig&) = default;
^
../include/hamlib/rigclass.h:44:23: warning: rvalue references are a C++11 extension [-Wc++11-extensions]
Rig& operator=(Rig&&) = default;
^
../include/hamlib/rigclass.h:44:29: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rig& operator=(Rig&&) = default;
^
6 warnings generated.
CXX rotclass.lo
In file included from rotclass.cc:36:
../include/hamlib/rotclass.h:41:31: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rotator(const Rotator&) = default;
^
../include/hamlib/rotclass.h:42:20: warning: rvalue references are a C++11 extension [-Wc++11-extensions]
Rotator(Rotator&&) = default;
^
../include/hamlib/rotclass.h:42:26: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rotator(Rotator&&) = default;
^
../include/hamlib/rotclass.h:43:42: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rotator& operator=(const Rotator&) = default;
^
../include/hamlib/rotclass.h:44:31: warning: rvalue references are a C++11 extension [-Wc++11-extensions]
Rotator& operator=(Rotator&&) = default;
^
../include/hamlib/rotclass.h:44:37: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rotator& operator=(Rotator&&) = default;
^
In file included from rotclass.cc:37:
../include/hamlib/rigclass.h:41:23: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rig(const Rig&) = default;
^
../include/hamlib/rigclass.h:42:12: warning: rvalue references are a C++11 extension [-Wc++11-extensions]
Rig(Rig&&) = default;
^
../include/hamlib/rigclass.h:42:18: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rig(Rig&&) = default;
^
../include/hamlib/rigclass.h:43:34: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rig& operator=(const Rig&) = default;
^
../include/hamlib/rigclass.h:44:23: warning: rvalue references are a C++11 extension [-Wc++11-extensions]
Rig& operator=(Rig&&) = default;
^
../include/hamlib/rigclass.h:44:29: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rig& operator=(Rig&&) = default;
^
12 warnings generated.
CXX ampclass.lo
In file included from ampclass.cc:37:
../include/hamlib/ampclass.h:41:35: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Amplifier(const Amplifier&) = default;
^
../include/hamlib/ampclass.h:42:24: warning: rvalue references are a C++11 extension [-Wc++11-extensions]
Amplifier(Amplifier&&) = default;
^
../include/hamlib/ampclass.h:42:30: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Amplifier(Amplifier&&) = default;
^
../include/hamlib/ampclass.h:43:46: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Amplifier& operator=(const Amplifier&) = default;
^
../include/hamlib/ampclass.h:44:35: warning: rvalue references are a C++11 extension [-Wc++11-extensions]
Amplifier& operator=(Amplifier&&) = default;
^
../include/hamlib/ampclass.h:44:41: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Amplifier& operator=(Amplifier&&) = default;
^
In file included from ampclass.cc:38:
../include/hamlib/rigclass.h:41:23: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rig(const Rig&) = default;
^
../include/hamlib/rigclass.h:42:12: warning: rvalue references are a C++11 extension [-Wc++11-extensions]
Rig(Rig&&) = default;
^
../include/hamlib/rigclass.h:42:18: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rig(Rig&&) = default;
^
../include/hamlib/rigclass.h:43:34: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rig& operator=(const Rig&) = default;
^
../include/hamlib/rigclass.h:44:23: warning: rvalue references are a C++11 extension [-Wc++11-extensions]
Rig& operator=(Rig&&) = default;
^
../include/hamlib/rigclass.h:44:29: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
Rig& operator=(Rig&&) = default;
^
12 warnings generated.
CXXLD libhamlib++.la

Am 09.03.2021 um 17:25 schrieb Black Michael mdblack98@yahoo.com:

Both of those are fixed now...and can you provide the C++ warnings?

Mike W9MDB

On Tuesday, March 9, 2021, 10:17:38 AM CST, Ch. van Wüllen vanwullen@chemie.uni-kl.de wrote:

obviously it should be HAMLIB_FILPATHLEN

P.S. I never saw this, but can reproduce the problem
when doing „make distcheck“

P.P.S.:Several new warnings are now triggered by recent commits,

ts990s.c:309:16: warning: implicit conversion from 'double' to 'int' changes value from -23.9 to -23 [-Wliteral-conversion]
.str_cal = TS990S_STR_CAL,
^~~~~~~~~~~~~~
ts990s.c:55:23: note: expanded from macro 'TS990S_STR_CAL'
{0x13, -23.9},
~ ^~~~~
ts990s.c:309:16: warning: implicit conversion from 'double' to 'int' changes value from -11.7 to -11 [-Wliteral-conversion]
.str_cal = TS990S_STR_CAL,
^~~~~~~~~~~~~~
ts990s.c:56:23: note: expanded from macro 'TS990S_STR_CAL'
{0x1B, -11.7},
~ ^~~~~

ftdx101.c:123:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
.str_cal = FTDX101D_STR_CAL,
^~~~~~~~~~~~~~~~
./ftdx101.h:151:26: note: expanded from macro 'FTDX101D_STR_CAL'
#define FTDX101D_STR_CAL { 12,
^~~~~~~
ftdx101.c:121:27: note: previous initialization is here
.str_cal = FTDX101D_STR_CAL,
^~~~~~~~~~~~~~~~
./ftdx101.h:151:26: note: expanded from macro 'FTDX101D_STR_CAL'
#define FTDX101D_STR_CAL { 12,
^~~~~~~

as well as some C++ complaints about C++11 extension (mostly defaulted function definitions).

Am 09.03.2021 um 16:50 schrieb Bill Somerville g4wjs@classdesign.com:

Hi all,

on macOS using Clang.

73
Bill
G4WJS.

<hamlib.log>_______________________________________________

Hamlib-developer mailing list
Hamlib-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/hamlib-developer

+---------------------------------+----------------------------------+
| Prof. Christoph van Wüllen | Tele-Phone (+49) (0)631 205 2749 |
| TU Kaiserslautern, FB Chemie | Tele-Fax (+49) (0)631 205 2750 |
| Erwin-Schrödinger-Str. | |
| D-67663 Kaiserslautern, Germany | vanWullen@Chemie.Uni-KL.De |
| |
| HomePage: http://www.chemie.uni-kl.de/vanwullen

             |

+---------------------------------+----------------------------------+

+---------------------------------+----------------------------------+
| Prof. Christoph van Wüllen | Tele-Phone (+49) (0)631 205 2749 |
| TU Kaiserslautern, FB Chemie | Tele-Fax (+49) (0)631 205 2750 |
| Erwin-Schrödinger-Str. | |
| D-67663 Kaiserslautern, Germany | vanWullen@Chemie.Uni-KL.De |
| |
| HomePage: http://www.chemie.uni-kl.de/vanwullen |
+---------------------------------+----------------------------------+