Invalid rig# does not create proper error

[mdblack98]

Ok but what should I call if I need list of supported rig model numbers and names? I need it to help users choose their rig. Because of model numbers change in 4.x is important to handle unknown models properly (return NULL and keep process alive).

If I omit rig_load_all_backends, then rig_list_foreach returns only models up to 6:

C:\temp\hamlib42exit\Debug>hamlib42exit.exe
rig_check_rig_caps: p1=56492520, p2=56497AE8, rig_model=56492520, macro_name=56497AE8
dummy.c(2465):initrigs4_dummy entered
initrigs4_dummy: _init called
rig_register called
rig_register: rig_register (1)
rig_register called
rig_register: rig_register (2)
rig_register called
rig_register: rig_register (4)
rig_register called
rig_register: rig_register (5)
rig_register called
rig_register: rig_register (6)
dummy.c(2474):initrigs4_dummy return(0)
ret=00000000
unreached
C:\temp\hamlib42exit\Debug>

#include "stdafx.h"
#include "stdio.h"
#include "hamlib/rig.h"

int func(const rig_caps *caps, rig_ptr_t)
{
printf("%d %s\n", caps->rig_model, caps->model_name);
return 1;
}

int _tmain(int argc, _TCHAR* argv[])
{
//rig_load_all_backends();
rig_list_foreach(func, NULL);
RIG *tmprig = rig_init(228); // unknown model
printf("ret=%p\n", tmprig);
printf("unreached");
}

If I uncomment rig_load_all_backends, result is:

...
32001 2050
32002 950
33001 FDM-DUO
rig_check_rig_caps: p1=56492520, p2=56497AE8, rig_model=56492520, macro_name=56497AE8
dummy.c(2465):initrigs4_dummy entered
initrigs4_dummy: _init called
rig_register called
rig_register: rig_register (1)
Hash collision!!! Fatal error!!

Note "ret" and "unreached" are not printed.

All this worked in 3.3.

[mdblack98]

This broke the c++ make check so reverting this change