Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IC_7300 VFO swapping #762

Closed
mdblack98 opened this issue Aug 13, 2021 · 0 comments
Closed

IC_7300 VFO swapping #762

mdblack98 opened this issue Aug 13, 2021 · 0 comments
Labels
bug enhancement JTDX Bugs affecting JTDX operations needs test Patches have been submitted but need testing to close issue WSJTX Bugs affecting WSTJ-X operations
Milestone
4.4

Comments

@mdblack98
Copy link
Contributor

mdblack98 commented Aug 13, 2021 •
edited

IC-7300 (and other rigs besides Icoms) are doing unnecessary VFO swapping.
Also Icom rigs are not properly setting VFOB unless set_vfo is called first.

#1 Reduce Icom swapping in hamlib
#2 Fix Icom set_vfo to use 0x25 command for set_freq
#3 Add RIG_TARGETABLE_VFO_NOSETNEEDED flag to rig caps targetable_vfo so clients can recognize hamlib does not need them to set vfo to change freq or mode. This is necessary to allow backwards compatibility for old hamlib which needed the set_vfo and will be in shared libraries.
#4 Add VFO_RX/VFO_TX capability so clients do not have to know about VFO at all or split mode or reverse split.
wn.
@mdblack98 mdblack98 added bug enhancement JTDX Bugs affecting JTDX operations WSJTX Bugs affecting WSTJ-X operations labels Aug 13, 2021
mdblack98 added a commit that referenced this issue Aug 13, 2021
@mdblack98
Fix Icom rigs to use 0x25 command if capable
014bc04 
Fixes #1 and and #2 in the issue
#762
@mdblack98 mdblack98 added this to the 4.4 milestone Aug 27, 2021
mdblack98 added a commit that referenced this issue Aug 27, 2021
@mdblack98
Allow all Icom, Kenwood, Yaesu to avoid VFO swapping
03fe6f6 
#762
#430
mdblack98 added a commit that referenced this issue Aug 27, 2021
@mdblack98
Fix possilbe segfault last patch
0d9bcbf 
#762
#430
mdblack98 added a commit that referenced this issue Aug 27, 2021
@mdblack98
Move TARGETABLE_PTT logic to the set_ptt routine
0016d5a 
#762
#430
mdblack98 added a commit that referenced this issue Aug 27, 2021
@mdblack98
Finish up targetable_ptt logic
5a0590d 
Was causing unnecessary vfo swapping
#762
#430
@mdblack98 mdblack98 added the needs test Patches have been submitted but need testing to close issue label Aug 27, 2021
mdblack98 added a commit that referenced this issue Aug 27, 2021
@mdblack98
Fix some more unnecessary vfo swapping
f6b54df 
#762
#430
mdblack98 added a commit that referenced this issue Aug 27, 2021
@mdblack98
Fix uninitialized warning in rig.c
b41f706 
    #762
    #430
mdblack98 added a commit that referenced this issue Aug 27, 2021
@mdblack98
Remove another unneeded vfo swap from icom rigs
06513a6 
#762
#430
mdblack98 added a commit that referenced this issue Aug 28, 2021
@mdblack98
Fix set_split_vfo to use correct RX vfo instead of TX vfo
f552e3f 
#762
#430
mdblack98 added a commit that referenced this issue Aug 28, 2021
@mdblack98
Remove unnecessary set_mode command from TARGETABLE_MODE Icom rigs
004efaf 
#762
#430
wutje pushed a commit to wutje/Hamlib that referenced this issue Sep 4, 2021
@mdblack98 @wutje
Allow all Icom, Kenwood, Yaesu to avoid VFO swapping
1c7b4ab 
Hamlib#762
Hamlib#430
wutje pushed a commit to wutje/Hamlib that referenced this issue Sep 4, 2021
@mdblack98 @wutje
Fix possilbe segfault last patch
6a9432a 
Hamlib#762
Hamlib#430
wutje pushed a commit to wutje/Hamlib that referenced this issue Sep 4, 2021
@mdblack98 @wutje
Move TARGETABLE_PTT logic to the set_ptt routine
3dde32f 
Hamlib#762
Hamlib#430
wutje pushed a commit to wutje/Hamlib that referenced this issue Sep 4, 2021
@mdblack98 @wutje
Finish up targetable_ptt logic
fcdacb2 
Was causing unnecessary vfo swapping
Hamlib#762
Hamlib#430
wutje pushed a commit to wutje/Hamlib that referenced this issue Sep 4, 2021
@mdblack98 @wutje
Fix some more unnecessary vfo swapping
d5028e7 
Hamlib#762
Hamlib#430
wutje pushed a commit to wutje/Hamlib that referenced this issue Sep 4, 2021
@mdblack98 @wutje
Fix uninitialized warning in rig.c
83590a0 
    Hamlib#762
    Hamlib#430
wutje pushed a commit to wutje/Hamlib that referenced this issue Sep 4, 2021
@mdblack98 @wutje
Remove another unneeded vfo swap from icom rigs
c04c4cb 
Hamlib#762
Hamlib#430
wutje pushed a commit to wutje/Hamlib that referenced this issue Sep 4, 2021
@mdblack98 @wutje
Fix set_split_vfo to use correct RX vfo instead of TX vfo
fe46bcf 
Hamlib#762
Hamlib#430
wutje pushed a commit to wutje/Hamlib that referenced this issue Sep 4, 2021
@mdblack98 @wutje
Remove unnecessary set_mode command from TARGETABLE_MODE Icom rigs
8092588 
Hamlib#762
Hamlib#430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement JTDX Bugs affecting JTDX operations needs test Patches have been submitted but need testing to close issue WSJTX Bugs affecting WSTJ-X operations
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
1 participant
@mdblack98