Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression from recent commit (set_level: Feature not available) #778

Closed
cjritola opened this issue Aug 29, 2021 · 4 comments
Closed

Regression from recent commit (set_level: Feature not available) #778

cjritola opened this issue Aug 29, 2021 · 4 comments
Labels
bug critical A problem for common operations with WSJT-X, GPredict, RigPi, etc. needs test Patches have been submitted but need testing to close issue
Milestone

Comments

@cjritola
Copy link
Contributor

rigctl -m 1 set_level PREAMP 0
set_level: error = Feature not available
read_string called, rxmax=1024
read_string(): RX 9 characters
rigctl_parse.c(3150):rigctl_set_level return(-11)

... issue arises in commit
d16fa49

Commenting parts of block starting at line 1000 in tests/rigctl_parse.c fixes it:

if (interactive)
            {
                rig_debug(RIG_DEBUG_TRACE, "%s: debug7\n", __func__);

                //arg1[0] = fgetc(fin);
                //arg1[1] = 0;

                if (prompt /* && arg1[0]  == 0x0a */)
                {

I was pulling my hair out trying to get my new code to work when I realized rig_caps.set_level wasn't even getting called. XD

Looks like the parser was passing an empty string to rig_parse_level() in declare_proto_rig(set_level). I don't understand what is happening beyond that.

@mdblack98
Copy link
Contributor

mdblack98 commented Aug 29, 2021 via email

@cjritola
Copy link
Contributor Author

How about this:

me@host:~/Hamlib$ rigctld -m 1 &
[1] 20946
me@host:~/Hamlib$ rigctl -m 2 -r localhost set_level PREAMP 1
set_level: error = Feature not available
read_string called, rxmax=1024
read_string(): RX 9 characters
rigctl_parse.c(3150):rigctl_set_level return(-11)

I think I got confused 7 hrs in.

@mdblack98 mdblack98 added bug critical A problem for common operations with WSJT-X, GPredict, RigPi, etc. labels Aug 29, 2021
@mdblack98 mdblack98 added the needs test Patches have been submitted but need testing to close issue label Aug 29, 2021
@mdblack98
Copy link
Contributor

mdblack98 commented Aug 29, 2021 via email

@cjritola
Copy link
Contributor Author

That fixed it, thanks

@mdblack98 mdblack98 modified the milestones: 4.3.1, 4.3 Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug critical A problem for common operations with WSJT-X, GPredict, RigPi, etc. needs test Patches have been submitted but need testing to close issue
Projects
None yet
Development

No branches or pull requests

2 participants