Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLL/Shared library testing #905

Closed
mdblack98 opened this issue Dec 27, 2021 · 1 comment
Closed

DLL/Shared library testing #905

mdblack98 opened this issue Dec 27, 2021 · 1 comment
Labels
api breakage
Milestone
4.5

Comments

@mdblack98
Copy link
Contributor

Add testrigcaps to testing routine to ensure changes do not break DLL/Shared library compatibility.
If such changes are necessary than it a major revision change will have to be done.
@mdblack98 mdblack98 added critical A problem for common operations with WSJT-X, GPredict, RigPi, etc. api breakage labels Dec 27, 2021
mdblack98 added a commit that referenced this issue Dec 27, 2021
@mdblack98
Add testrigcaps to make check
d2d622a 
#905
@mdblack98 mdblack98 added this to the 4.5 milestone Dec 28, 2021
@mdblack98 mdblack98 added the needs test Patches have been submitted but need testing to close issue label Dec 28, 2021
@mdblack98
Copy link
Contributor Author

testrigcaps still needs checking on multiple platforms to determine the correct offsets but currently works for 64-bit build on Linux and Windows.
We use offsets into rig->caps to check if they change so it varies by compiler, structure padding, and architecture

@mdblack98 mdblack98 removed the critical A problem for common operations with WSJT-X, GPredict, RigPi, etc. label Dec 29, 2021
@mdblack98 mdblack98 removed the needs test Patches have been submitted but need testing to close issue label Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api breakage
Projects
None yet
Milestone
4.5
Development

No branches or pull requests
1 participant
@mdblack98