Levels 3 #1297
Merged
Levels 3 #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use more data already in rig->caps instead of hard coding values.
Turn on checking against level_gran on the TS-890S, so I can eat my own dog food.
Add limits for 0.0-1.0 float values.
Drop duplicate RFPOWER_METER, add TEMP_METER.
Fill in more holes. This should cover the Kenwood and Elecraft rigs, with most of the callers of kenwood_set_level vetted. Also fills in some other data in rig->caps. Still looking for a way to (programatically) verify that AGC data is checked and processed correctly.
And now that the comment parses, fix the check to respect it. I seriously doubt anyone will ever use this, but you never know.
|
Do "make distcheck".
Looks like you forgot to add a file
https://github.com/Hamlib/Hamlib/actions/runs/5032970733/jobs/9026903170?pr=1297
Mike W9MDB
On Saturday, May 20, 2023 at 10:46:26 AM CDT, GeoBaltz ***@***.***> wrote:
Next set of changes for issue #1144
Adds more info to rig->caps, adds new defaults for Elecraft gear, minor fixes.
Enables the level_gran checks on the TS-890 - I've been running this way for a couple of weeks with no problems.
…________________________________
You can view, comment on, or merge this pull request online at:
#1297
Commit Summary
* 05f0473 Round 3 of level_gran updates.
* ea37ad1 Remove hard-coded constants.
* 7a69042 Enable full level checking for TS-890S.
* 3029260 Add default level values for Elecraft rigs.
* d27283c Update RIG_LEVEL_READONLY_LIST.
* d3c2ebc Round 4 of level_gran updates.
* e5f6b4e Fix the comment about float levels.
File Changes (16 files)
* M include/hamlib/rig.h (4)
* M rigs/icom/ic7300.c (3)
* M rigs/icom/level_gran_icom.h (4)
* M rigs/kenwood/flex6xxx.c (8)
* M rigs/kenwood/k2.c (4)
* M rigs/kenwood/k3.c (22)
* A rigs/kenwood/level_gran_elecraft.h (30)
* M rigs/kenwood/level_gran_kenwood.h (6)
* M rigs/kenwood/ts590.c (8)
* M rigs/kenwood/ts870s.c (1)
* M rigs/kenwood/ts890s.c (91)
* M rigs/kenwood/ts930.c (1)
* M rigs/kenwood/xg3.c (4)
* M rigs/yaesu/ftdx101mp.c (1)
* M rigs/yaesu/level_gran_yaesu.h (6)
* M src/misc.c (17)
Patch Links:
* https://github.com/Hamlib/Hamlib/pull/1297.patch
* https://github.com/Hamlib/Hamlib/pull/1297.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next set of changes for issue #1144
Adds more info to rig->caps, adds new defaults for Elecraft gear, minor fixes.
Enables the level_gran checks on the TS-890 - I've been running this way for a couple of weeks with no problems.