Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Lunette 0.3.1 to Spoons repo #142

Closed
wants to merge 3 commits into from

Conversation

scottwhudson
Copy link

Add Lunette to Spoons repository

@cmsj
Copy link
Member

cmsj commented Sep 11, 2019

I'm happy to merge Lunette, but I think we need to look at some of the docstrings - for our automatic doc generator to work, the docstrings lines need to start with three - rather than Lua's normal two.
There also needs to be a little section formatted like lines 1-4 of https://github.com/Hammerspoon/Spoons/blob/master/Source/Caffeine.spoon/init.lua#L1 so we can generate the doc table of contents and page titles properly.

Let me know if I explained that poorly, our docstring stuff is all homegrown and a bit fragile, unfortunately!

@scottwhudson
Copy link
Author

Howdy @cmsj , sorry this fell off my radar.

I've made the requested docstring changes, lmk if there's anything else I can do!

@scottwhudson
Copy link
Author

Howdy @cmsj, is there anything else you need from me on this?

1 similar comment
@scottwhudson
Copy link
Author

Howdy @cmsj, is there anything else you need from me on this?

@cmsj
Copy link
Member

cmsj commented May 21, 2020

@scottwhudson very sorry, it seems I'm not getting proper notifications for this repo. Do you still want to merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants