MenubarFlag: Add detection based on currentMethod() when available #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some keyboard layouts are not detected by hs.keycodes.currentLayout() but by hs.keycodes.currentMethod(). Use whichever of the two has a value to get the current layout. This fixes detection for Chinese and other layouts. Reported and fixed originally by @liukun at zzamboni/dot-hammerspoon#7
This was referenced Jun 5, 2017
Closed
zzamboni
changed the title
|
Closing in favor of #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some keyboard layouts are not detected by hs.keycodes.currentLayout()
but by hs.keycodes.currentMethod(). Use whichever of the two has
a value to get the current layout. This fixes detection for Chinese
and other layouts. Reported and fixed originally by @liukun
at zzamboni/dot-hammerspoon#7