New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Crash Reporter privacy #139

Closed
cmsj opened this Issue Nov 16, 2014 · 10 comments

Comments

Projects
None yet
2 participants
@cmsj
Copy link
Member

cmsj commented Nov 16, 2014

The core we inherited from Mjolnir is very stable, but it's likely that we have bugs in some of the extensions. It would be good to have a crash reporter in HS, preferably one that submits to a free service!

@cmsj cmsj added this to the 1.0 milestone Nov 16, 2014

@cmsj cmsj added the enhancement label Nov 16, 2014

@cmsj

This comment has been minimized.

Copy link
Member

cmsj commented Dec 17, 2014

AFAICT, our "best" free option here, is to combine PLCrashReporter ( https://www.plcrashreporter.org/documentation/api/v1.2/interface_p_l_crash_reporter.html#a988eedc5625bf6ecc475c998274e341d ) with something like http://stackoverflow.com/questions/1619731/send-email-through-a-cocoa-application which is all pretty complicated and gross :(

@cmsj cmsj closed this in dc70a1a Dec 23, 2014

@asmagill

This comment has been minimized.

Copy link
Member

asmagill commented Mar 9, 2015

I've been away a bit, and I've not looked too closely at the crashlytics code yet, so if this is posted somewhere, please let me know so I can review it... does HS have a way to disable crash reporting? A posted privacy policy about what is being sent when a crash occurs? As with anything that goes on behind the scenes, collecting user data should always be an opt in ( or at a minimum provide a way to opt out ) kind of thing.

Sorry if this is covered elsewhere... it just hit me that I hadn't seen anything like this addressed anywhere yet...

@cmsj

This comment has been minimized.

Copy link
Member

cmsj commented Mar 9, 2015

@asmagill we are currently failing to live up to expectations on the crash reporting front. It was pushed in swiftly to handle a rising tide of awful crash bugs, but the failure to get it properly exposed to users, is entirely mine, and I apologise for that.

I would strongly prefer it to be opt-out, because I fear that opt-in will drastically reduce the quantity of crash reports we get. However, if people feel strongly in the other direction, then I will blame them for unfixable crash bugs, and make it opt-in ;)

Let's re-open this issue and figure out how we present this

@cmsj cmsj reopened this Mar 9, 2015

@cmsj

This comment has been minimized.

Copy link
Member

cmsj commented Mar 9, 2015

So, how about another entry in the prefs window, of the form:

[✔] Send anonymous crash reports

Perhaps then a little Privacy Policy link underneath it, which goes to something on www.hammerspoon.org with some painfully non-legalese that says "This is what gets collected, it's hosted by Crashlytics.com (part of Twitter), we will never sell or give the data to anyone else, here is Crashlytics' privacy policy"

Thoughts?

@cmsj cmsj changed the title Crash reporter Implement Crash Reporter privacy Mar 9, 2015

@asmagill

This comment has been minimized.

Copy link
Member

asmagill commented Mar 9, 2015

Personally, I prefer opt-in things, but I'm fine with opt out, as long as it's in a reasonably easy place to see... the prefs dialog is perfect -- you're guaranteed to see it at least once when you first install HS. I understand the need for good crash data, especially as a programmer, but I really don't like when things aren't transparent...

It's not that I disagree with the purpose... it just struck me that I don't know much about how it works or what it collects, and realized that this is the kind of thing that so many complain about with regards to privacy! We definitely don't want anyone shying away from HS because of uncertainty.

On Mar 9, 2015, at 3:26 PM, Chris Jones notifications@github.com wrote:

So, how about another entry in the prefs window, of the form:

[✔] Send anonymous crash reports
Perhaps then a little Privacy Policy link underneath it, which goes to something on www.hammerspoon.org http://www.hammerspoon.org/ with some painfully non-legalese that says "This is what gets collected, it's hosted by Crashlytics.com (part of Twitter), we will never sell or give the data to anyone else, here is Crashlytics' privacy policy"

Thoughts?


Reply to this email directly or view it on GitHub #139 (comment).

@cmsj

This comment has been minimized.

Copy link
Member

cmsj commented Mar 9, 2015

@Asmagil completely agreed. I should have tackled this much earlier.

FWIW I feel very conflicted about the default state of the checkbox. I would prefer it to be opt-in, but the numbers I've seen show that would have a massively negative impact on the number of people submitting crash reports. I think opt-out is ok, because as you say, it's right there in the first run prefs window.

cmsj added a commit that referenced this issue Mar 9, 2015

Add a preferences option to disable Crashlytics, and a link to a priv…
…acy policy page on hammerspoon.org. Relates to #139
@cmsj

This comment has been minimized.

Copy link
Member

cmsj commented Mar 9, 2015

@asmagill What do you think about 47dbd78 ? It should cover our needs here, I think. Similarly, what do you think about the contents of http://www.hammerspoon.org/privacy.html ?

@asmagill

This comment has been minimized.

Copy link
Member

asmagill commented Mar 9, 2015

Looks good to me! I'm ok with closing this again unless anyone else has anything else to add.

On Mar 9, 2015, at 5:03 PM, Chris Jones notifications@github.com wrote:

@asmagill https://github.com/asmagill What do you think about 47dbd78 47dbd78 ? It should cover our needs here, I think. Similarly, what do you think about the contents of http://www.hammerspoon.org/privacy.html http://www.hammerspoon.org/privacy.html ?


Reply to this email directly or view it on GitHub #139 (comment).

@cmsj

This comment has been minimized.

Copy link
Member

cmsj commented Mar 9, 2015

@asmagill cool, thanks. I'd like @Habbie to chime in, particularly on the Privacy Policy, before closing the issue.

@cmsj

This comment has been minimized.

Copy link
Member

cmsj commented Mar 10, 2015

07:06:49 @Habbie Ng, the privacy policy appeared to be missing a lot of full stops at end of sentences when i read it last night
07:06:55 @Habbie Ng, otherwise it looks great :)

closing :)

@cmsj cmsj closed this Mar 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment