[READY] Added hs.webview.toolbar.uniqueName() #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
latenitefilms
commented
Aug 23, 2019
•
latenitefilms
commented
- Closes Add hs.webview.toolbar.get? #2109
latenitefilms
changed the title
hs.webview.toolbar.uniqueName()hs.webview.toolbar.uniqueName()
latenitefilms
changed the title
hs.webview.toolbar.uniqueName()
asmagill
reviewed
Aug 23, 2019
There was a problem hiding this comment.
Do we really need to create the toolbar? I was thinking something along the lines of lua_pushboolean(L, ![identifiersInUse containsObject:identifier]) should be sufficient.
This assumes that the only toolbars in the Hammerspoon application space are created by this module (identifiersInUse is only updated here)... I guess creating the toolbar and then letting ARC collect it is the definitive test...
Thoughts?
|
@asmagill - Very good point! Fixed! |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.