[REVIEW] Fixes bug in MJConfigDir #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reverts code so that `hs.configdir` works as it did back in Hammerspoon 0.9.78 (5164) - specifically, we have changed `[[MJConfigFile stringByStandardizingPath] stringByResolvingSymlinksInPath]` back to `[MJConfigFile stringByStandardizingPath]`. This reverts the changes made in Hammerspoon#2359. - The code that checks for a Spoons path now uses `MJConfigDirAbsolute` instead of `MJConfigDir` to work around an issue discussed in Hammerspoon#2357. - Closes Hammerspoon#2478
latenitefilms
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hs.configdirworks as it did back in Hammerspoon 0.9.78 (5164) - specifically, we have changed[[MJConfigFile stringByStandardizingPath] stringByResolvingSymlinksInPath]back to[MJConfigFile stringByStandardizingPath]. This reverts the changes made in make MJConfigFile resolve symlinks #2359.MJConfigDirAbsoluteinstead ofMJConfigDirto work around an issue discussed in Double-Clicking an Installed Spoon Deletes It #2357.