add -Wno-declaration-after-statement for Xcode 14.3 #3474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@cmsj, @latenitefilms if there are no objections, tomorrow I'm going to go ahead and merge this pull and #3476 because they both included fixes that are required to build Hammerspoon under the latest Xcode. I hope to be uploading a new pull request for hs.hash and hs.fs soon after and it will be easier if these have already landed, to hopefully avoid conflicts that require manual fixes later on. |
|
@asmagill I think I already merged fixes for this by now, but fwiw these flags belong in the xcconfig files in https://github.com/Hammerspoon/hammerspoon/tree/master/Hammerspoon/Build%20Configs (typically in the relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest XCode/Clang is prepping for C2x and apparently its must stickier about some things... I had to add
-Wno-declaration-after-statementto both the Hammerspoon and LuaSkin projects to get them to compile.