Added number of rounds and carthage support #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added shadow path (optional) Allowed to set different back track width.
Updated project with: + number of rounds (same as Apple bedtime control_ + shadow track offset and color + Time.Unit type alias + shared framework scheme
Added: + example code + shadow track + number of rounds inspectable + example project clock type selection Changed: * fixed M_PI deprecation warnings
# Conflicts: # CHANGELOG.md # Example/HGCircularSlider.xcodeproj/project.pbxproj # HGCircularSlider.podspec # HGCircularSlider/Classes/CircularSliderHelper.swift
There was a problem hiding this comment.
Hi Andrzej,
Thanks for your great work.
You find below some suggestions / comments
-
We should add the property
numberOfRoundsto CircularSlider class instead of RangeCircularSlider -
We should add documentation to
delta(in interval: Interval, for angle: CGFloat, oldValue: CGFloat) -> CGFloat- backtrackLineWidth
- trackShadowOffset
-
We should remove the structure
struct Timefrom the source code; we can add it to the example if needed -
We should keep the distance in
RangeCircularSlider(sometimes we need to fix the distance between start thumb and endThumb) -
We should keep the code to secure the values of
endPointValueandstartPointValue, this code fix also an issue (in this version) in midPointCircularSlider example
Best regards,
Hamza
|
Please look at #16 |
This was referenced Apr 17, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I have added number of rounds and shadow track to RangeCircularSlider, so it is possible to fully mimic Apple bedtime feature now. Added carthage support (with prebuilt binary) as well.
I have also reintroduced example project, adding a segmented control on clock pane, to show difference between 1 and 2 rounds.
Thanks again for the library - it works pretty nice and I have good experience using it. I removed previous pull request, and merged recent changes into my fork - so it should be possible to merge this automatically now.