Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacGUI: Improper Button State #1220

Closed
avenged110 opened this issue Mar 9, 2018 · 4 comments
Closed

MacGUI: Improper Button State #1220

avenged110 opened this issue Mar 9, 2018 · 4 comments
Assignees
@galad87
Labels
System or Player Issue

Comments

@avenged110
Copy link

Description of problem

The "show presets" button doesn't respond properly when clicked. It should just darken like the others when clicked, but instead shows a light gray box around it.

HandBrake version

20180227205614-369b4f6-master

Operating system and version

OS X 10.9.5 (13F1911)

Screenshot

this one
@sr55 sr55 added the Bug label Mar 9, 2018
@bradleysepos
Copy link
Contributor

Hmm. I can't reproduce this on 10.13.4 @1x or @2x high ppi (Retina), with regular or small size icons. Guessing it's an odd bug in vintage macOS itself.

@bradleysepos
Copy link
Contributor

Double-checked the graphics files and there's nothing special about that one. Could have something to do with the popover/legacy code or just macOS being funny.

@sr55 sr55 added this to the 1.1.1 milestone Jun 11, 2018
@jstebbins jstebbins modified the milestones: 1.1.1, 1.1.2 Jun 19, 2018
@sr55
Copy link
Contributor

sr55 commented Aug 7, 2018

@galad87 would this be corrected in the current builds or a non-issue now due to dropping 10.9?

@sr55
Copy link
Contributor

sr55 commented Aug 19, 2018 •
edited
Loading

It's a non issue with 10.10 as far as I can tell. I'm inclined to close this since we no longer support 10.9. It's a minor cosmetic issue so it's not really worth worrying about.

@sr55 sr55 closed this as completed Aug 19, 2018
@sr55 sr55 modified the milestones: 1.1.2, Unscheduled Aug 19, 2018
@bradleysepos bradleysepos removed this from the Unscheduled milestone Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galad87 galad87

Labels
System or Player Issue
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bradleysepos @sr55 @jstebbins @galad87 @avenged110