1.4.1 Incorrect Filter List added to queue (Linux UI)

[soulshadow]

Problem Description

While testing different denoise settings in the GUI I stumbled upon an issue where the Denoise filter (mainly NLMeans) is still added to the "Filterlist" section in the queue entry when set to "Off".

I tested this by opening a source file (.mkv, though I doubt that is relevant) selected basic options for Video and Audio. The only filter (other than crop under the dimmensions tab) in use is Denoise: NLMeans and any combination of Denoise Presets and Tunes.

I then added it to the queue.

Then I went back, changed the Denoise filter to "off", typed a new output filename and added that to the queue.

upon examination of the queue file the "uiSettings" section includes
"PictureDenoiseFilter": "off",
"PictureDenoisePreset": "",
"PictureDenoiseTune": "film"

while above in the section:
"Filters": {
"Filterlist": [
{
"ID": 9,
"Settings": {
//cb- and y- settings corresponding to "light" preset with "film" tune
// ...

Further testing showed that subsequently enabling the "HQDN3D" filter would result in both filter "ID": 8 and "ID": 9 being present in the filterlist, regardless of what is selected in the GUI.

Additional testing showed that if the denoise filter is set to "off" when (before) a source file is opened then the filter will be off when added to the queue. BUT if a denoise filter is already selected prior to opening a source file, or if it is selected at any time afterward, then it will always be present in the queue's filterlist section, no matter what selections are made in the GUI.

Activity Log, Crash Log or any other details

can provide exported queue file, if needed.

What Operating System are you running?

Slackware Linux -current

What version of HandBrake are you running?

1.4.1

Where did you download HandBrake from?

alienbob's slackware repo: https://slackware.nl/people/alien/restricted_slackbuilds/handbrake/

[sr55]

@jstebbins Looks like it is indeed adding filter id's it shouldn't be.

[jstebbins]

Fixed. Thanks for reporting this.