dvd: add widescreen vobsubs when letterbox is permitted #355
Conversation
libhb/dvd.c
Outdated
| switch (style) | ||
| { | ||
| case HB_VOBSUB_STYLE_4_3: | ||
| strcat( subtitle->lang, " (4:3)" ); |
There was a problem hiding this comment.
Nit: brackets here instead of parens?
There was a problem hiding this comment.
Do you mean in the text? e.g. [4:3]? Why would that be "better"? Parens match the other descriptive items we append to the description.
There was a problem hiding this comment.
In my experience, brackets are commonly used for technical additions. Similar to in jurnalizm [sic]. No biggie, just avoids multiple sets of parens.
There was a problem hiding this comment.
The description shown in the CLI and GUI does have a lot of parens. Adding different punctuation is going to look a bit strange.
e.g.
CLI: English (Closed Caption) (Wide Screen) (iso639-2: eng) (Bitmap)(VOBSUB)
GUI: English (Closed Caption) (Wide Screen) (VOBSUB)
I was just being a good lemming.
We could probably eliminate a lot of what the CLI is showing. I'm pretty sure it was there so the WinGui could parse out everything it needed to know when it was a CLI wrapper.
How about reformatting the whole thing to something like this?
English, Closed Caption [Wide Screen, VOBSUB]
The problem with doing this is it makes the patch much more extensive. Everything after the "(Wide Screen)" part is added by the frontend. So we would have to go around and change all the frontends as well. I would suggest just having libhb build the full description and remove this extra code from the frontends.
But now this is heading in directions this patch really wasn't intended to go. So my suggestion is that reformatting should be a separate patch as well.
There was a problem hiding this comment.
Agreed. Sounds like a plan.
Now I want to play Lemmings. DOS, of course!
| strcat( subtitle->lang, " (Closed Caption)" ); | ||
| break; | ||
| case 6: | ||
| strcat( subtitle->lang, " (Closed Caption with bigger size character)" ); |
There was a problem hiding this comment.
Is "with bigger size character" a standard description? If not, I suggest "Closed Caption, Large Type". Same for other instances.
There was a problem hiding this comment.
That would be for a different patch. This is the wording we currently use. I didn't change it.
There was a problem hiding this comment.
Okay. Wasn't sure whether it was new.
|
Great work, John. Initial read looks good. |
We were only adding subtitle tracks specifically designed for letterbox when letterbox is permitted. We should also add the subtitle tracks that are specifically designed for wide screen.
We were only adding subtitle tracks specifically designed for letterbox
when letterbox is permitted. We should also add the subtitle tracks
that are specifically designed for wide screen.