Add image sequence input (not fully merged back, Linux gui not added) #4461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he CLI; Has repercussions for gtk,macos,win so these commits are not buildable.
sr55
reviewed
Mar 29, 2023
| @@ -33,6 +33,8 @@ | |||
| "AudioSecondaryEncoderMode": true, | |||
| "AudioTrackSelectionBehavior": "first", | |||
| "ChapterMarkers": true, | |||
| "ImageSequence": false, | |||
There was a problem hiding this comment.
Should these really be part of the preset keys?
Seems more like something that should be handled at source selection.
Ask for it up-front and maybe remember the last used framerate.
There was a problem hiding this comment.
Could be, I'm not too far into the project so I don't know about this kind of choice. Feel free to do with this what you think best, I think in this case I just took the quickest route to adding the functionality this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change:
As discussed in Issue #2346
Using the image2 demuxer, adds the option for using an image sequence as input.
Option toggle is added to macOS and Windows GUI, not yet to Gtk version.
Tested on: